Initialize fRefCnt in rapidxml XML file implementations#174
Open
key2 wants to merge 1 commit into
Open
Conversation
CXMLFileImpl and CXMLFileNodeImpl implement IVWUnknown reference counting manually but never initialized fRefCnt in their constructors. With typical glibc heap contents the garbage value is non-zero, so the objects are never destroyed (silent leak); on allocators that return zeroed pages (e.g. a fresh WebAssembly heap) Release() is entered with fRefCnt == 0 and triggers the 'fRefCnt > 0' assert for every node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CXMLFileImplandCXMLFileNodeImpl(rapidxmlsupport, used withDONT_USE_XERCES_AS_XMLLIB) implementIVWUnknownreference counting manually, but their constructors never initializefRefCnt. The member starts with whatever the allocator returns.Effects
Release()and every XML file/node object is leaked silently.Release()is entered withfRefCnt == 0and prints thefRefCnt > 0assert for every single node while parsing — thousands of lines per GDTF/MVR file.Fix
Initialize
fRefCnt = 0in both constructors, matching whatVCOMImpl<T>does for all other implementations.Verified by parsing all files from gdtf-share samples with the rapidxml backend: no assert output, objects are correctly destroyed.