Revise the RPackage::installedFiles() implementation#207
Open
amaa-99 wants to merge 1 commit into
Open
Conversation
amaa-99
force-pushed
the
39-merge-revise-the-rpackageinstalledfiles-implementation
branch
from
2243d65 to
710166e
Compare
Changed the implementation to return std::string instead of relying on a static variable for storage lifetime. Avoided calling FileExists() twice in case the file was already found. Added returning an informative message in case the list can't be retrieved. Added skipping the insertion of empty lines instead of relying on a single empty line always being read from the input file. Removed the unused HAVE_RPM variant of RPackage::installedFiles().
amaa-99
force-pushed
the
39-merge-revise-the-rpackageinstalledfiles-implementation
branch
from
710166e to
9847b30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the implementation to return std::string instead of relying on a static variable for storage lifetime.
Avoided calling FileExists() twice in case the file was already found.
Added returning an informative message in case the list can't be retrieved.
Added skipping the insertion of empty lines instead of relying on a single empty line always being read from the input file. Removed the unused HAVE_RPM variant of RPackage::installedFiles().
(closes amaa-99#38)