Skip to content

Make subsonic provider check for extension it uses#4874

Merged
OzGav merged 1 commit into
music-assistant:devfrom
khers:extension-check
Jul 21, 2026
Merged

Make subsonic provider check for extension it uses#4874
OzGav merged 1 commit into
music-assistant:devfrom
khers:extension-check

Conversation

@khers

@khers khers commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

We recently bumped into a problem with a new Open Subsonic implementation that does not support the 'formpost' extension. This relies on that extension and should check for it early and fail early if it is not available.

Related issue (if applicable):

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • New music/player/metadata/plugin provider — new-provider
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — documentation
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Checklist

  • The code change is tested and works locally.
  • pre-commit run --all-files passes.
  • pytest passes, and tests have been added/updated under tests/ where applicable.
  • I have read and complied with the project's AI Policy for any AI-assisted contributions.

@khers

khers commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Do I need to do anything more to enable the translation of the two new exception messages?

@khers
khers requested a review from OzGav July 20, 2026 14:27
@OzGav

OzGav commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

To make them translatable you would add this or similar

raise LoginFailed(
    msg,
    translation_key="extensions_query_failed",
    translation_owner=self.translation_owner,
) from e

and then in strings.json errors block add

  "extensions_query_failed": "Failed to query server for OpenSubsonic extensions",
  "formpost_not_supported": "Server does not support the 'formpost' OpenSubsonic extension, which is required."

@khers

khers commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, I will add that to the PR when I get home this evening.

We recently bumped into a problem with a new Open Subsonic
implementation that does not support the 'formpost' extension. This
relies on that extension and should check for it early and fail early if
it is not available.

Signed-off-by: Eric B Munson <[email protected]>
@khers
khers force-pushed the extension-check branch from ad32899 to db70b54 Compare July 20, 2026 23:25
@khers

khers commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Translation entries should be all set now.

@OzGav OzGav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @khers !

@OzGav
OzGav merged commit 67d3f79 into music-assistant:dev Jul 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants