Make subsonic provider check for extension it uses#4874
Merged
Conversation
Contributor
Author
|
Do I need to do anything more to enable the translation of the two new exception messages? |
Contributor
|
To make them translatable you would add this or similar and then in strings.json errors block add |
Contributor
Author
|
Thanks, I will add that to the PR when I get home this evening. |
We recently bumped into a problem with a new Open Subsonic implementation that does not support the 'formpost' extension. This relies on that extension and should check for it early and fail early if it is not available. Signed-off-by: Eric B Munson <[email protected]>
Contributor
Author
|
Translation entries should be all set now. |
OzGav
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently bumped into a problem with a new Open Subsonic implementation that does not support the 'formpost' extension. This relies on that extension and should check for it early and fail early if it is not available.
Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementnew-providerbreaking-changerefactordocumentationmaintenancecidependenciesChecklist
pre-commit run --all-filespasses.pytestpasses, and tests have been added/updated undertests/where applicable.