Skip to content

Remove tx pool shard computation #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefangutica merged 2 commits into from
Jul 9, 2026
+2 −12
Merged

Remove tx pool shard computation #1614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d6b6d9
remove tx pool shard computation
stefangutica Jul 8, 2026
8e38bda
add newline
stefangutica Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/endpoints/pool/pool.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import { TransactionType } from "../transactions/entities/transaction.type";
import { TransactionInPool } from "./entities/transaction.in.pool.dto";
import { PoolFilter } from "./entities/pool.filter";
import { TxInPoolFields } from "src/common/gateway/entities/tx.in.pool.fields";
import { AddressUtils } from "@multiversx/sdk-nestjs-common";
import { ProtocolService } from "../../common/protocol/protocol.service";
import { TransactionActionService } from "../transactions/transaction-action/transaction.action.service";
import { Transaction } from "../transactions/entities/transaction";
import { ApiUtils } from "@multiversx/sdk-nestjs-http";
Expand All @@ -21,7 +19,6 @@ export class PoolService {
private readonly gatewayService: GatewayService,
private readonly apiConfigService: ApiConfigService,
private readonly cacheService: CacheService,
private readonly protocolService: ProtocolService,
private readonly transactionActionService: TransactionActionService,
) { }

Expand Down Expand Up @@ -96,22 +93,15 @@ export class PoolService {
value: tx.value ?? '',
gasPrice: tx.gasprice ?? 0,
gasLimit: tx.gaslimit ?? 0,
senderShard: tx.sendershard ?? 0,
receiverShard: tx.receivershard ?? 0,
data: tx.data ?? '',
guardian: tx.guardian ?? '',
guardianSignature: tx.guardiansignature ?? '',
signature: tx.signature ?? '',
type: type ?? TransactionType.Transaction,
});

// TODO: after gateway's /transaction/pool returns the sendershard and receivershard correctly, remove this computation
const shardCount = await this.protocolService.getShardCount();
if (transaction.sender) {
transaction.senderShard = AddressUtils.computeShard(AddressUtils.bech32Decode(transaction.sender), shardCount);
}
if (transaction.receiver) {
transaction.receiverShard = AddressUtils.computeShard(AddressUtils.bech32Decode(transaction.receiver), shardCount);
}

const metadata = await this.transactionActionService.getTransactionMetadata(this.poolTransactionToTransaction(transaction), false);
if (metadata && metadata.functionName) {
transaction.function = metadata.functionName;
Expand Down
Loading