Bug 1764713 - Easily switch between open/closed/both combined bugs in bug search list#2638
Merged
Merged
Conversation
dklawren
requested changes
Jun 9, 2026
dklawren
left a comment
dklawren
left a comment
Collaborator
There was a problem hiding this comment.
Looks good but needs a few minor changes. Thanks!
Contributor
Author
|
BMO Test Suite / test_sanity failed cause of the 3 'grep' added at lines 893,896 and 899. |
dklawren
requested changes
Jun 12, 2026
…rk mode support --link-color is not defined anywhere in the codebase. The correct variable is --link-text-color (defined in global.css with a dark-mode variant). Also removes the hardcoded #0060df fallback on the active button background, which had poor contrast in dark mode
For named/saved searches, $params is reassigned to a fresh Bugzilla::CGI($buffer) containing bug_status, while $cgi only holds the raw request params. So bug_status is empty there, causing the toggle to always show "All" active for saved searches
… buttons Toggle links were missing &order=$qorder, silently dropping the user's custom sort when switching between Open/Closed/All. Consistent with all other navigation links in this template (e.g. "all search results", "Change Several Bugs at Once", and "Remember search" links)
… coupled to bug_status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a quick-toggle widget at the top of the bug list results page (buglist.cgi), allowing users to switch between open, closed or all bugs without returning to the search form.
Details
buglist.cgi
template/en/default/list/list.html.tmpl
<div class="bz_status_toggle">immediately after the<hr>separator, containing three controls: Open, Closed, All<span>; the other two are<a>links pointing to the current search with bug_status=open, bug_status=closed, or bug_status=all appendedskins/standard/buglist.css
Adds styles for the toggle widget following the existing bz_ naming convention:
.bz_status_toggle: Flex container for the widget.bz_status_toggle_label: "Show:" label.bz_status_toggle_btn: Individual button (link or span).bz_status_toggle_btn:hover: Hover state for inactive buttons.bz_status_toggle_btn.active: Active/selected button (filled with --link-color)How it works
The search engine already understands bug_status=open, bug_status=closed, and bug_status=all as special aliases that expand to the appropriate status sets at query time, so the toggle links are simple and require no server-side changes to the search logic.
Additional info
Test plan