[WIP/Parked] Vesta upgrade to React 19 - #1513
Open
dtm2451 wants to merge 8 commits into
Open
Conversation
…0-alpha). packages only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is saves the state of an incomplete upgrade that ended up not being needed. It upgrades vesta to use a Node 24 base image, React 19, Nextjs 15, and MaterialUI v6.1.1 conssitently (instead of mixing that MUI v6.1.1 with some v5.0.0-alpha).
Most Material UI elements were able to be reconnected with just updates to 'import' lines, but some components were changed in breaking ways or removed altogether:
<FocusTrap>component was removed altogether from MUI, but could be just safely deleted from the location it was used (mobile-render main nav menu).<Option>component was removed altogether from MUI. Commit 0ca7d93 includes incomplete code changes that attempted to replace the component with<MenuItem>. Likely fixable simply, but it appeared that<Select>behavior or something else acted different in the the update. Used for mobile-render (thin browser window) selection of the stats graph time-scale in the main about page.Related Resourcesmenu became busted by a change that was not attempted to be fixed at the time.Also:
Also note:
visxdependency did not have a full release with compatibility for React 19 yet, so an alpha version was used. Likely that can be corrected to a stable-release by the time we might come back to this work.