Skip to content

[WIP/Parked] Vesta upgrade to React 19 - #1513

Open
dtm2451 wants to merge 8 commits into
masterfrom
db/vesta-react-19
Open

[WIP/Parked] Vesta upgrade to React 19#1513
dtm2451 wants to merge 8 commits into
masterfrom
db/vesta-react-19

Conversation

@dtm2451

@dtm2451 dtm2451 commented May 29, 2026

Copy link
Copy Markdown
Contributor

The PR is saves the state of an incomplete upgrade that ended up not being needed. It upgrades vesta to use a Node 24 base image, React 19, Nextjs 15, and MaterialUI v6.1.1 conssitently (instead of mixing that MUI v6.1.1 with some v5.0.0-alpha).

Most Material UI elements were able to be reconnected with just updates to 'import' lines, but some components were changed in breaking ways or removed altogether:

  • <FocusTrap> component was removed altogether from MUI, but could be just safely deleted from the location it was used (mobile-render main nav menu).
  • <Option> component was removed altogether from MUI. Commit 0ca7d93 includes incomplete code changes that attempted to replace the component with <MenuItem>. Likely fixable simply, but it appeared that <Select> behavior or something else acted different in the the update. Used for mobile-render (thin browser window) selection of the stats graph time-scale in the main about page.
  • The Related Resources menu became busted by a change that was not attempted to be fixed at the time.
  • Changes to 'vesta/vesta_ui/src/theme.ts' seem in line with version updates, but their necessity / continued functionality was not confirmed.

Also:

Also note:

  • The visx dependency did not have a full release with compatibility for React 19 yet, so an alpha version was used. Likely that can be corrected to a stable-release by the time we might come back to this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant