log metrics for metis uploads - #1481
Closed
amadeovezz wants to merge 1 commit into
Closed
Conversation
amadeovezz
changed the title
graft
reviewed
Mar 15, 2026
| "upload_complete project=#{project_name} bucket=#{bucket.name} " \ | ||
| "file=#{file_name} size_bytes=#{data_block.size} " \ | ||
| "duration_seconds=#{'%.3f' % duration} bytes_per_sec=#{bps}" | ||
| ) |
Contributor
There was a problem hiding this comment.
seems to just send this to stdout rather than to the ledger? Those logs are pretty ephemeral.
Contributor
Author
There was a problem hiding this comment.
I didn't want to an a upload_started_at column to the ledger model just for this use case. I thought you were just testing one off use cases that you would be manually monitoring?
If we want something query-able we will need a different strategy
Contributor
There was a problem hiding this comment.
i thought we were putting this in the ledger so we could monitor upload speeds in general, i can always time client-side for one-off use cases. It should be pretty straightforward to just send the same content to the ledger instead of stdout, no?
Contributor
Author
|
closed - work is moving to #1462 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal change set to get some metrics in prod for metis uploads