vulcan FE - hook up file streaming as 'any-file-link' - #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
#stream_download_fileendpoint to an output that can be specified in a workflow's 'vulcan_config.json' asui_component: "any-file-link".#download_fileendpoint, which only works forcat-able files, as"text-file-link"to be more obvious about this constraint."link"output name is very soft. Code comment only. We should not document this option when building that documentation!Some thoughts around UI-component deprecation:
We likely want to give 1) a warning message in the browser view of the workspace when there are deprecated components in the workspace's vulcan_config.json, and 2) Remove those options from documentation or properly document them as deprecated.
But I don't think it's time to build the warning message as there is a good chance we'll have an upgraded platform for doing so by the time such warning will become truly needed! A.k.a. a messaging system that allows message levels and allows holding back messages already shown to a user during a given time interval. The for this messaging now is currently LOW as we control all workflows && the only deprecation (this one) only represents a name change with the old name remaining hooked up to maintained code!