Conversation
…cal-channel brick
v0.6.0 shipped with the protocol major living in three independent copies:
Go proto.go ProtocolVersion ("2"), the SSH channel's
REMOTE_AGENT_PROTOCOL_MAJOR ("2"), and the local channel's
AGENT_PROTOCOL_VERSION in shared/agent/envelope.ts — still "1". Every
local workspace failed the Ready handshake with
server.protocol-version-mismatch and the release was pulled. The SSH-only
E2E never exercised the local channel, so the drift shipped.
envelope.ts is now THE single source of truth: the SSH constant and the
pipe's fallback alias it, build-agent.ts manifest metadata imports it, and
a new cross-language sync test reads proto.go directly so any future
one-sided bump fails CI. Test fixtures emit ready frames derived from the
constant instead of literals, and the validation-semantics suite is
version-agnostic.
Verified against the real binary: dist agent (stdio mode) advertises
protocolVersion=2, local channel expectation now matches.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.6.0 첫 발행본은 프로토콜 major가 3곳에 독립 사본으로 존재한 채 한 곳(로컬 채널
envelope.ts= "1")이 누락되어 모든 로컬 워크스페이스의 Ready 핸드셰이크가 실패했다. 릴리즈/태그 철회 후 본 수정으로 재발행한다.Fix
shared/agent/envelope.ts의AGENT_PROTOCOL_VERSION을 단일 진실원으로 승격 ("2")internal/proto/proto.go를 직접 읽어 TS 상수와 대조하는 테스트 — 한쪽만 범프하면 CI 실패Verification
protocolVersion=2↔ 로컬 채널 기대 2 일치🤖 Generated with Claude Code