Skip to content

use older 2.0.4 version of whatwg-fetch in browser core package#302

Open
neonguru wants to merge 1 commit into
mongodb:masterfrom
neonguru:master
Open

use older 2.0.4 version of whatwg-fetch in browser core package#302
neonguru wants to merge 1 commit into
mongodb:masterfrom
neonguru:master

Conversation

@neonguru

Copy link
Copy Markdown

This resolves issue #186
The whatwg-fetch module is responsible for the window is not defined error.
By using the previous version of that module, the error does not occur and everything works as required.
Tested in my SSR application and it is working as intended.

@adamchel

Copy link
Copy Markdown
Contributor

Haven't had the time to look at this too closely yet, but @neonguru do you have any idea what changed in whatwg-fetch between 2.0.4 and 3.0.0 that caused the window is not defined error? Would it perhaps be better to open an issue/PR with whatwg-fetch itself?

@adamchel

Copy link
Copy Markdown
Contributor

I'm hesitant to downgrade a dependency without understanding what changed.

@neonguru

Copy link
Copy Markdown
Author

There is an issue in their repo already regarding this:
JakeChampion/fetch#657

@neonguru

Copy link
Copy Markdown
Author

But it's going on a year that they've known about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants