revert(data-service): set readPreference to primary unconditionally in previewUpdate COMPASS-10872#8256
Merged
Conversation
…lly in p…" This reverts commit a219925.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a recent data-service behavior change around previewUpdate() transaction configuration, restoring prior semantics where the transaction’s read preference is not forcibly overridden.
Changes:
- Removes the unconditional
ReadPreference.primaryoverride from thepreviewUpdate()transaction options. - Removes the spec that previously asserted
previewUpdate()succeeds under a non-primary connection read preference.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/data-service/src/data-service.ts | Reverts transaction option behavior for previewUpdate() by no longer forcing primary read preference. |
| packages/data-service/src/data-service.spec.ts | Removes the test that documented/supports previewUpdate() behavior under non-primary read preference. |
Anemy
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8250
https://www.conventionalcommits.org/en/v1.0.0/#how-does-conventional-commits-handle-revert-commits