Skip to content

fix: improve handling of unescaped chars in connection strings COMPASS-10688#8246

Open
paula-stacho wants to merge 2 commits into
mainfrom
COMPASS-10688-3
Open

fix: improve handling of unescaped chars in connection strings COMPASS-10688#8246
paula-stacho wants to merge 2 commits into
mainfrom
COMPASS-10688-3

Conversation

@paula-stacho

Copy link
Copy Markdown
Collaborator

Description

🎉

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mongodb-connection-string-url dependency across several Compass workspaces to pick up the 7.0.2 patch (COMPASS-10688) and refreshes the lockfile accordingly.

Changes:

  • Bump mongodb-connection-string-url from ^7.0.1 to ^7.0.2 across multiple workspace package.json files.
  • Update package-lock.json to reflect the new dependency resolution.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/data-service/package.json Bumps mongodb-connection-string-url to ^7.0.2 in data-service deps.
packages/connection-storage/package.json Bumps mongodb-connection-string-url to ^7.0.2 in connection-storage deps.
packages/connection-info/package.json Bumps mongodb-connection-string-url to ^7.0.2 in connection-info deps.
packages/connection-form/package.json Bumps mongodb-connection-string-url to ^7.0.2 in connection-form deps.
packages/compass/package.json Bumps mongodb-connection-string-url to ^7.0.2 in compass dev deps.
packages/compass-generative-ai/package.json Bumps mongodb-connection-string-url to ^7.0.2 in generative-ai deps.
packages/compass-e2e-tests/package.json Bumps mongodb-connection-string-url to ^7.0.2 in e2e test deps.
packages/compass-connections/package.json Bumps mongodb-connection-string-url to ^7.0.2 in compass-connections deps.
packages/compass-collection/package.json Bumps mongodb-connection-string-url to ^7.0.2 in compass-collection deps.
packages/compass-assistant/package.json Bumps mongodb-connection-string-url to ^7.0.2 in compass-assistant deps.
configs/testing-library-compass/package.json Bumps mongodb-connection-string-url to ^7.0.2 in testing helpers config.
package-lock.json Updates lockfile to include 7.0.2 resolutions and related transitive updates.

@paula-stacho paula-stacho changed the title fix: update mongodb-connection-string-url COMPASS-10688 fix: improve handling of unescaped chars in connection strings COMPASS-10688 Jul 16, 2026
onSaveClicked={noop}
/>
);
expect(screen.getByText('Invalid connection string "pineapples"')).to.be

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this not work anymore?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connection string can include credentials, so it was decided to skip it from the error messages. It also wasn't adding any value as it was just the original string which the client already has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants