fix: improve handling of unescaped chars in connection strings COMPASS-10688#8246
Open
paula-stacho wants to merge 2 commits into
Open
fix: improve handling of unescaped chars in connection strings COMPASS-10688#8246paula-stacho wants to merge 2 commits into
paula-stacho wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the mongodb-connection-string-url dependency across several Compass workspaces to pick up the 7.0.2 patch (COMPASS-10688) and refreshes the lockfile accordingly.
Changes:
- Bump
mongodb-connection-string-urlfrom^7.0.1to^7.0.2across multiple workspacepackage.jsonfiles. - Update
package-lock.jsonto reflect the new dependency resolution.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/data-service/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in data-service deps. |
| packages/connection-storage/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in connection-storage deps. |
| packages/connection-info/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in connection-info deps. |
| packages/connection-form/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in connection-form deps. |
| packages/compass/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in compass dev deps. |
| packages/compass-generative-ai/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in generative-ai deps. |
| packages/compass-e2e-tests/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in e2e test deps. |
| packages/compass-connections/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in compass-connections deps. |
| packages/compass-collection/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in compass-collection deps. |
| packages/compass-assistant/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in compass-assistant deps. |
| configs/testing-library-compass/package.json | Bumps mongodb-connection-string-url to ^7.0.2 in testing helpers config. |
| package-lock.json | Updates lockfile to include 7.0.2 resolutions and related transitive updates. |
nbbeeken
approved these changes
Jul 16, 2026
paula-stacho
force-pushed
the
COMPASS-10688-3
branch
from
July 17, 2026 09:27
89939bc to
f6a97c8
Compare
nbbeeken
approved these changes
Jul 17, 2026
esvm
reviewed
Jul 17, 2026
| onSaveClicked={noop} | ||
| /> | ||
| ); | ||
| expect(screen.getByText('Invalid connection string "pineapples"')).to.be |
Collaborator
Author
There was a problem hiding this comment.
The connection string can include credentials, so it was decided to skip it from the error messages. It also wasn't adding any value as it was just the original string which the client already has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🎉
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes