fix(compass-aggregations): remove static whitelist for search stage errors COMPASS-10449#8241
Open
pavithrachidambaram-afk wants to merge 1 commit into
Open
fix(compass-aggregations): remove static whitelist for search stage errors COMPASS-10449#8241pavithrachidambaram-afk wants to merge 1 commit into
pavithrachidambaram-afk wants to merge 1 commit into
Conversation
pavithrachidambaram-afk
marked this pull request as ready for review
July 15, 2026 20:48
pavithrachidambaram-afk
force-pushed
the
COMPASS-10449
branch
from
July 16, 2026 20:56
3c6c6b2 to
ee32ab5
Compare
…hase 2 search stage errors COMPASS-10449 Phase 1 keeps its existing whitelist-driven "Edit Search Index" link unchanged. For Phase 2, bypass the static regex whitelist entirely and always show the "Debug" button instead, so the assistant handles diagnosis rather than depending on an unsustainable list of error patterns.
pavithrachidambaram-afk
force-pushed
the
COMPASS-10449
branch
from
July 16, 2026 21:10
ee32ab5 to
05b9826
Compare
JimmyChoiMDB
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes how the
$searchserver error banner (ServerErrorBanner) decides between showing an "Edit Search Index" link and a "Debug" button — an error categorized as an index definition issue could show the link in normal view but only the Debug button in fullscreen/focus mode. Ties to the Phase 3 TODO in COMPASS-10449 to replace the whitelist with assistant-based categorization.isSearchIndexDefinitionError) to decide between the "Edit Search Index" link and the Debug button, including the existing mode-dependent quirkDebugbutton —showEditSearchIndexLinkis now additionally gated on!enableSearchActivationProgramP2, so no whitelist reliance and no mode-dependent linkwrapWithExperimentProvidertest helper to accept a per-experiment variant map, so a test can assign a user to multiple experiments (e.g. both Phase 1 and Phase 2) at once instead of only a single shared variantBefore:
Now (only for Phase 2, Phase 1 will be unchanged):

Checklist
Motivation and Context
Open Questions
None.
Dependents
None.
Types of changes