fix(embed): conformance mock + TypeScript router vs the real Monad API [PRO-455] - #17
Open
Credgate wants to merge 2 commits into
Open
fix(embed): conformance mock + TypeScript router vs the real Monad API [PRO-455]#17Credgate wants to merge 2 commits into
Credgate wants to merge 2 commits into
Conversation
…of [PRO-455]
The mock returned every row regardless of `limit` and had no
`GET /v1/{org}/{kind}s/{id}` route at all, so it could not catch two bugs the
routers actually have: they never send `limit` (Monad defaults it to 10) and
they walk the whole pipeline list to answer a question `component_of` answers
in one call.
- page every list at Monad's default limit of 10, with no maximum
- serve the connector detail route, including `component_of` — pinned to the
same narrow projection the datastore emits (no `status`, no `nodes`)
- accept `type` on output create, `output_type` staying a deprecated alias
- track connectors statefully so a delete is observable
- add the >10-pipelines scenario; it fails against the pre-fix routers
Credgate
requested review from
alastaird-monad,
andrewc-monad,
brenth-monad,
mattj-monad,
mon-aneesh and
saikapuluru99
as code owners
August 4, 2026 16:39
This was referenced Aug 4, 2026
…[PRO-455] Review of the Go port (#15) surfaced defects the TypeScript reference has too. Validated against the API source rather than the published spec, which is stale. - resolve a connector's pipeline via `GET /v1/{org}/{kind}s/{id}`'s `component_of` instead of scanning every pipeline. The scan sent no `limit`, so past the tenant's tenth pipeline it reported "not connected" for pipelines that exist. - `setEnabled` now PATCHes `{enabled}` alone. PATCH became a true partial update in api#2163; the read-modify-write it replaces silently dropped node `config_overrides` and edge `schema_detection_spec` on every toggle. - drain the connector list instead of one `limit=1000` request - send `type` on output create; `output_type` is deprecated (api#2156) - drop the speculative `data` / `config` response-shape fallbacks — Monad returns neither - map `kind` to its path segment explicitly rather than appending "s"
Credgate
force-pushed
the
feature/pro-455
branch
from
August 4, 2026 16:41
6e88f9b to
9dbe1af
Compare
Credgate
marked this pull request as draft
August 4, 2026 17:10
Credgate
marked this pull request as ready for review
August 4, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of the Go router (#15) surfaced defects the TypeScript reference has too — and the conformance mock could not have caught any of them. It returned every row regardless of
limit, and had noGET /v1/{org}/{kind}s/{id}route at all, so CI was green on a bug that bites the eleventh pipeline.First of three stacked fix PRs (PRO-455 → PRO-456 → PRO-457), one per router. Every claim was validated against the API source in
monad-inc/api, not the published spec —sdk/openapi.jsonis ~15 months stale.Linear: PRO-455
The mock now reproduces the real API
limitof 10, with no maximum (api/pkg/routes/v2/routes/pipelines.go:727)component_of, pinned to the same narrow projection the datastore actually emits — nostatus, nonodes(core/pkg/datastore/postgres/pipelines.go:292). A too-generous mock here would let a router pass locally and fail live.typeon output create,output_typestaying a deprecated aliastest_status_resolves_past_the_first_page_of_pipelinesis the gate: it fails against the pre-fix routers and passes after.TypeScript router
The same six fixes that follow for Go and Python, so the three stay identical on the wire. Detail is in the commit message; the two that matter:
component_of— the old scan sent nolimit, so past a tenant's tenth pipeline it reported "not connected" for pipelines that existsetEnabledPATCHes{enabled}alone. PATCH became a true partial update in api#2163; the read-modify-write it replaces rebuilt the graph from a partial field list, silently dropping nodeconfig_overridesand edgeschema_detection_specon every toggle.Reviewer note
One behavior change worth a look: an unknown connector id now returns
404 not_foundinstead of200 {hasPipeline:false}, since resolution goes through a connector fetch.test_ingress_lifecycleasserts the new shape after removal.Verification
pnpm test13/13, conformanceROUTER=ts35/35 (ROUTER=goandROUTER=pythonalso green on this mock, unchanged).