Skip to content

Enable Finder Wi-Fi sync from the device view#43

Merged
momenbasel merged 1 commit into
momenbasel:mainfrom
AJV20:feat/wifi-sync-enable
Jul 18, 2026
Merged

Enable Finder Wi-Fi sync from the device view#43
momenbasel merged 1 commit into
momenbasel:mainfrom
AJV20:feat/wifi-sync-enable

Conversation

@AJV20

@AJV20 AJV20 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a USB-only Enable Wi-Fi action that maps to Finder's "Show this iPhone when on Wi-Fi" setting via pymobiledevice3 lockdown wifi-connections --state on
  • Retry after pairing/trust if needed, but do not treat pairing alone as successful Wi-Fi enablement
  • Treat pymobiledevice3 lockdown stderr error markers such as Device not found as failures even when the CLI exits 0
  • Add a Backup quick action on the Device page, including a linear loading bar and sanitized Backing up progress copy
  • Correct current iPhone18,* model mappings so iPhone18,2 displays as iPhone 17 Pro Max
  • Invalidate device discovery caches and show guidance to unplug, keep the device unlocked, and rescan
  • Bump local app bundle version to 1.0.11

Verification

  • Scripts/regression/run.py
  • swift build
  • swift build -c release
  • bash Scripts/build.sh
  • Installed /Applications/Phosphor.app and launched version 1.0.11 with a visible window

@AJV20
AJV20 force-pushed the feat/wifi-sync-enable branch 2 times, most recently from 41fe125 to d7dcd14 Compare July 8, 2026 19:08
@AJV20
AJV20 force-pushed the feat/wifi-sync-enable branch from d7dcd14 to 789cf32 Compare July 8, 2026 19:16
@momenbasel
momenbasel merged commit a9ab52e into momenbasel:main Jul 18, 2026
2 checks passed
@momenbasel

Copy link
Copy Markdown
Owner

Merged into main - this closes #45. The wifi-connections change is the right fix: the old path reported success after pairing alone, which never flips Finder's "Show this iPhone when on Wi-Fi" flag. Resolved the BackupViewModel overlap with #33 by keeping the operation-ID progress guard and routing through this PR's updateBackupProgress helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants