feat: add PDF message exports#42
Merged
Merged
Conversation
AJV20
marked this pull request as draft
July 7, 2026 11:35
Owner
|
Merged into main after fixing the one blocker: exportPDF built its reply-lookup map with Dictionary(uniqueKeysWithValues:), which traps on duplicate GUIDs - and GUIDs come from the untrusted sms.db, so a corrupted or merged backup would crash the app mid-export. Switched to Dictionary(_:uniquingKeysWith:) keeping the first occurrence, and forwarded cancellationCheck into the PDF path so large exports stay cancelable. Two smaller items left as follow-ups: timestamps render every 8th message, and a bubble whose in-line cards exceed a full page can drop trailing body text. Neither blocks the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
swift buildScripts/regression/run.py(33 checks)Scripts/build.sh%PDF-1.3file with multi-page outputScripts/check-pr-scope.sh origin/main