WIP: chore: validate rspack version with manifest#4887
Conversation
🦋 Changeset detectedLatest commit: 1d30d96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2heal1
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d30d96a1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return; | ||
| } | ||
|
|
||
| // webpack + legacy rspack | ||
| if (this._bundler === 'rspack') { |
There was a problem hiding this comment.
With Rspack configs that rely on this wrapper's longstanding default (manifest omitted), StatsPlugin still reaches this branch because undefined !== false, but packages/rspack/src/ModuleFederationPlugin.ts passes the same undefined option to Rspack's native ModuleFederationPlugin. The native plugin has not been explicitly enabled to emit mf-stats.json, so this new error fires during processAssets instead of producing the default manifest as before (for example, apps/manifest-demo/3010-rspack-provider/rspack.config.js omits manifest). Please normalize omitted manifests to true before invoking Rspack or keep the legacy fallback for that case.
Useful? React with 👍 / 👎.
| if (!isRspackManifestSupported(rspackVersion)) { | ||
| throw new Error( | ||
| `[ ${PLUGIN_IDENTIFIER} ]: Rspack ${rspackVersion || 'unknown'} does not support the required built-in manifest capability. Please upgrade to Rspack 1.7.12 or 2.0.0 and above.`, |
There was a problem hiding this comment.
This guard makes every Rspack manifest build fail below 1.7.12, but the workspace still resolves existing manifest/demo Rspack apps to older @rspack/core versions (for example apps/manifest-demo/3010-rspack-provider is locked to 1.3.9 in pnpm-lock.yaml), and I checked .github/workflows/devtools.yml: it runs pnpm run app:manifest:dev and app:manifest:prod. As committed, those CI jobs throw during plugin application before tests start; update the affected package specs/lockfile or opt those configs out of manifest generation along with this guard.
Useful? React with 👍 / 👎.
1 participant
Description
Related Issue
Types of changes
Checklist