chore: pass explicit validate= to root Container in tests#3
Merged
Conversation
Future-proofs the suite against the upcoming UnvalidatedContainerWarning (FutureWarning) that modern-di 2.x will emit for root containers built without an explicit validate argument, and dogfoods graph validation. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an explicit
validate=Trueargument to the two bare rootmodern_di.Container(...)constructions in the test suite (tests/conftest.py:15,tests/test_lifespan.py:43).README.mdalready passedvalidate=Trueexplicitly, so no change was needed there.Why
The next
modern-di2.x minor introducesUnvalidatedContainerWarning(aFutureWarning) when a root container is built without an explicitvalidateargument. Passing it explicitly now future-proofs this suite against that warning noise once the dependency is bumped, and dogfoods graph validation in our own tests. The graphs in both sites validated cleanly, sovalidate=Falsewas not needed anywhere.Note: the currently pinned
modern-direlease doesn't emit the warning yet, so this PR does not assert on it — just adds the explicit argument.Test plan
just test-ci(100% coverage gate) passesjust lint-cipasses🤖 Generated with Claude Code