Skip to content

Feat/refractor llm provider#914

Merged
alcholiclg merged 9 commits into
modelscope:mainfrom
alcholiclg:feat/refractor_llm
Jul 7, 2026
Merged

Feat/refractor llm provider#914
alcholiclg merged 9 commits into
modelscope:mainfrom
alcholiclg:feat/refractor_llm

Conversation

@alcholiclg

Copy link
Copy Markdown
Collaborator

Change Summary

  1. refractor llm provider: data-driven provider layer with 10 providers

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
  • Documentation reflects the changes where applicable

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the MS-Agent framework by introducing a knowledge-driven skill system (v2) integrated directly into the standard agent loop, a data-driven LLM provider layer with adaptive retry, a pluggable retriever framework, and a robust project/session management system. The code review identified several critical security and stability issues, including path traversal bypass vulnerabilities in path resolution, potential TypeError and ValueError crashes during streaming merges and string splitting, ZeroDivisionError risks in the BM25 retriever, and Windows compatibility issues with Path.rename().

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ms_agent/project/workspace.py
Comment thread ms_agent/skill/skill_tools.py Outdated
Comment thread ms_agent/llm/transport/openai_compat.py Outdated
Comment thread ms_agent/llm/transport/openai_compat.py
Comment thread ms_agent/llm/deepseek_llm.py Outdated
Comment thread ms_agent/skill/catalog.py
Comment thread ms_agent/retriever/bm25.py
Comment thread ms_agent/command/router.py
Comment thread ms_agent/project/store.py Outdated
@alcholiclg alcholiclg merged commit 951f9b6 into modelscope:main Jul 7, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants