feat: add get_parameters to CustomFunction - #352
Open
abhilash-kumar-nair wants to merge 1 commit into
Open
Conversation
A custom function's signature gives each parameter a human-readable display name and a description, and both were dropped when the signature was parsed: only the name, value, type and enumeration values survived. A caller presenting parameters to someone was left with the raw name, which is not what Modelon Impact shows — the 'dynamic' function's stop time is named 'final_time' and displayed as 'Stop Time', a difference no reformatting of the name recovers. Keep both on the parameter, and add get_parameters() to reach them. parameter_values stays a dict of names to values and is unchanged, so nothing that reads values behaves differently; get_parameters() is for the cases that need to describe a parameter rather than evaluate it. _Parameter becomes CustomFunctionParameter now that it is returned from a public method rather than held internally. display_name falls back to the name when the signature declares none, so a caller can use it unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.