fix: preserve zip modes when packing on Windows#254
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #235.
mcpb packalready collects each file's mode, but the packing path only wrote ZIP Unix external attributes on non-Windows platforms. A bundle built on Windows therefore lost the mode metadata needed when it was later unpacked on Linux or macOS.This writes Unix mode attributes on every platform. Binary entry points still get execute bits added before the mode is stored, so Windows-built binary bundles preserve the same cross-platform behavior as Unix-built bundles.
To verify
yarn test test/cli.test.ts --runInBandyarn lintyarn buildgit diff --check