Skip to content

add dummy rule for duckdb installs#64

Merged
irm-codebase merged 4 commits into
mainfrom
fix/duckdb-plugin
Jun 15, 2026
Merged

add dummy rule for duckdb installs#64
irm-codebase merged 4 commits into
mainfrom
fix/duckdb-plugin

Conversation

@irm-codebase

@irm-codebase irm-codebase commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes #60

Summary of changes in this pull request

  • Added a dummy rule with a core: 1 limit to avoid the parallel race condition caused by duckDB's plug in approach.

This does not fix the problem if multiple instances of the module are imported, unfortunately. The new scenarios approach diminishes the need for that, though.

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

@irm-codebase

Copy link
Copy Markdown
Collaborator Author

@ddahawkins-TUDelft feel free to test this branch of the module. Should fix all your problems.
Keep in mind that this uses a new approach in the configuration (multi-scenario configurations are now supported).

@irm-codebase irm-codebase left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked all files.

  • Tests pass.
  • Dummy file lands on the top of resources/automatic/
  • pathvars are used throughout the new rules.

@irm-codebase irm-codebase merged commit b6f067b into main Jun 15, 2026
4 checks passed
@irm-codebase irm-codebase deleted the fix/duckdb-plugin branch June 15, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel Race Condition on Windows with DuckDB Extension

1 participant