Skip to content

Add convention version to INTERFACE#28

Merged
irm-codebase merged 5 commits into
mainfrom
feature/add-spec-version
Jun 23, 2026
Merged

Add convention version to INTERFACE#28
irm-codebase merged 5 commits into
mainfrom
feature/add-spec-version

Conversation

@irm-codebase

@irm-codebase irm-codebase commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Added convention_version to INTERFACE.yaml.

Things to note:

  • REGEX for semver is enforced, with the caveat that 'v' prefixes are accepted (e.g., both 1.0.1 and v1.0.1 are accepted).
  • clio_tools will see any valid semver string as valid. For now, clio_tools does not see as its job to reject or accept any version.
  • This is only to allow quick dismissal of unsupported versions by other tools (i.e., the Modelblocks website, automated parsers, etc).

Also, I removed some shapefiles that were in this repo. They were leftovers from ec_modules.

@irm-codebase irm-codebase self-assigned this Jun 23, 2026
@irm-codebase irm-codebase changed the title Add modelblocks_convention to INTERFACE Add convention version to INTERFACE Jun 23, 2026
@irm-codebase irm-codebase requested a review from jnnr June 23, 2026 14:07

@jnnr jnnr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor comments. Could show all fixtures together for readability, but not pushing for it.

Comment thread tests/data_module_test/utils/interface_no_resources.yaml Outdated
Comment thread tests/data_module_test/io_test.py Outdated
@irm-codebase irm-codebase merged commit 255b9bb into main Jun 23, 2026
4 checks passed
@irm-codebase irm-codebase deleted the feature/add-spec-version branch June 23, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants