Skip to content

fix: wrongly wrap iife expressions#254

Merged
gmegidish merged 1 commit into
mainfrom
fix-webview-iife-bug
Jun 4, 2026
Merged

fix: wrongly wrap iife expressions#254
gmegidish merged 1 commit into
mainfrom
fix-webview-iife-bug

Conversation

@gmegidish
Copy link
Copy Markdown
Member

No description provided.

@gmegidish gmegidish merged commit 611db0d into main Jun 4, 2026
9 of 10 checks passed
@gmegidish gmegidish deleted the fix-webview-iife-bug branch June 4, 2026 19:28
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fff6dcef-57c2-4559-a466-04932c224206

📥 Commits

Reviewing files that changed from the base of the PR and between f9ac819 and 306e869.

📒 Files selected for processing (1)
  • devices/android_webview.go

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

This PR updates the ensureReturnExpression function in the Android WebView handler to enforce more consistent wrapping of evaluated expressions. The function now trims leading/trailing whitespace, removes trailing semicolons, and wraps all expressions that do not already start with a return keyword as return (<expr>). This replaces the previous heuristic approach that conditionally skipped wrapping based on the presence of statement separators or block syntax.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-webview-iife-bug

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant