fix: correct multi-factor IPCA solver - #12
Merged
Conversation
4 tasks
stefan-jansen
added a commit
to stefan-jansen/machine-learning-for-trading
that referenced
this pull request
Jul 27, 2026
The pre-existing >=0.1.0a6 pin already carried the fix for the multi-factor (K>1) IPCA solver (PR ml4t/models#12), but the CI Docker image was never rebuilt after that pin landed, so ml4t/ml4t:latest was still running the pre-fix a4 solver. 0.1.0b0 is the current PyPI release (beta readiness: docs, examples, additive exports, no core solver changes since a6) and is what the next image rebuild should pick up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.1.0a6releaseImpact
The previous implementation could permute coefficients when
n_factors > 1. Existing one-factor recovery coverage could not detect this. Accepted IPCA predictions in four ML4T case studies will be regenerated after this release; PCA, CAE, SDF, and SAE paths are unaffected.Verification
uv run ruff check src/ tests/uv run ruff format --check src/ tests/uv run ty checkuv run pytest tests/ -q(66 passed)uv build