fix: anchor drawdowns at high-water marks - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.1.0b25.Why
The prior implementation set
peak_dateto the observation immediately before a drawdown crossed the configured threshold. For gradual declines, this shortened the reported drawdown and assigned the wrong peak date. The corrected scan continuously tracks the latest high-water mark outside a drawdown.User impact
Drawdown tables and downstream reports now show the true peak date and full peak-to-recovery duration. Maximum drawdown depth is unchanged.
Validation
uv run pytest tests/test_evaluation/test_portfolio_analysis.py -q- 70 passeduv run pytest tests/ -q -n auto --timeout 120- 5,287 passed, 21 skippeduv run ruff check src/ tests/test_evaluation/test_portfolio_analysis.pyuv run ruff format --check src/ tests/test_evaluation/test_portfolio_analysis.pyuv run ty checkpre-commit run --all-files