LIN-5183 Linkify each tracking number field independently#43
Merged
Conversation
:contains('Tracking Number') also matches the new 'Return Tracking
Number' label, so the combined link list was written into both cells.
Process each matching field's cell on its own.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
ram-ku
approved these changes
Jul 1, 2026
ram-ku
left a comment
ram-ku
left a comment
There was a problem hiding this comment.
Clean, minimal fix. Wrapping the selector in .each() correctly processes each tracking cell independently, and getTrackingUrls's trailing .filter(v.length > 0) keeps a blank Return Tracking cell safe (no crash on empty). Jira LIN-5183 matches and testing instructions are thorough. Nice reuse of the existing helper unchanged.
gwatt
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:contains('Tracking Number')also matches the new 'Return Tracking Number' label, so the combined link list was written into both cells. Process each matching field's cell on its own.