Fix to #50 - Call Conn.close() and prevent it being reused if pooled.#56
Open
MarkSonghurst wants to merge 5 commits into
Open
Fix to #50 - Call Conn.close() and prevent it being reused if pooled.#56MarkSonghurst wants to merge 5 commits into
MarkSonghurst wants to merge 5 commits into
Conversation
added 5 commits
March 16, 2017 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix made #50 used Conn.Close() which worked fine for non-pooled connections, but was not closing pooled connections and so returning unusable connections to the pool.
This fix applies uses conn.close() which closes the connection regardless of if it's in a pool or not.
If the connection was pooled then the pool will create a new connection to replace it.
I also ran go fmt.
All unit tests pass.