Skip to content

Fix spurious failure in mempool tests#2085

Merged
ImplOfAnImpl merged 2 commits into
masterfrom
mempool_fix_test_tx_graph_generation
Jul 1, 2026
Merged

Fix spurious failure in mempool tests#2085
ImplOfAnImpl merged 2 commits into
masterfrom
mempool_fix_test_tx_graph_generation

Conversation

@ImplOfAnImpl

@ImplOfAnImpl ImplOfAnImpl commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

There was a failure in the storage_capacity_shrinkage test due to generate_transaction_graph_generic running out of utxos to spend. I revamped generate_transaction_graph_generic so that now it wastes only a small portion of the initial amount even in the worst case, so it's possible to use it to generate large tx graphs now.

Edit: there was another spurious test failure, this time due to cluster limit violation in transaction_graph_subset_permutation, so I pushed another commit.
Edit: I also updated anyhow to fix a cargo-deny error. This was moved to the base PR.

@ImplOfAnImpl ImplOfAnImpl marked this pull request as ready for review June 26, 2026 16:57
@ImplOfAnImpl ImplOfAnImpl requested a review from anyxem June 30, 2026 10:48
@ImplOfAnImpl ImplOfAnImpl force-pushed the mempool_fix_test_tx_graph_generation branch from c6309b2 to 2a724b4 Compare July 1, 2026 10:04
@ImplOfAnImpl ImplOfAnImpl changed the base branch from master to update_codeowners July 1, 2026 10:04
Base automatically changed from update_codeowners to master July 1, 2026 13:23
@ImplOfAnImpl ImplOfAnImpl merged commit c0d4824 into master Jul 1, 2026
20 checks passed
@ImplOfAnImpl ImplOfAnImpl deleted the mempool_fix_test_tx_graph_generation branch July 1, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants