Improve serialization compatibility#68
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves serialization interoperability by making shape() accept GeoJSON-like LinearRing payloads (commonly emitted via __geo_interface__) and adds a dedicated test suite validating pickle and joblib/loky multiprocessing round-trips for core and sub-geometry objects.
Changes:
- Extend
shape()to normalize{"type": "LinearRing", ...}payloads into a Ring-derived polygon geometry. - Add comprehensive multiprocessing/serialization regression tests (pickle + joblib/loky).
- Add
joblibtorequirements.txtto support the new loky/joblib tests.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
togo.pyx |
Updates shape() docs and adds a LinearRing normalization path for GeoJSON-like dict inputs. |
tests/test_multiprocessing_serialization.py |
Introduces new regression tests covering shape(LinearRing) parsing and pickle/loky round-trips for geometry objects and sub-objects. |
requirements.txt |
Adds joblib to ensure loky/joblib transfer tests can run in the standard test environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved serialization compatibility: ToGo now accepts
LinearRingpayloads inshape()and supports robust pickle/loky round-trips for geometry sub-objects (e.g., polygon exterior/boundary), reducing multiprocessing deserialization failures.