Shapely-like force_2d plus more segfault-related hardening#65
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the project’s segfault/memory-safety hardening by adding explicit initialization checks to several Geometry accessors/predicates, introducing a GEOS-backed binary union() overlay operation, and adding regression tests + documentation updates around these safety guarantees.
Changes:
- Added
_ensure_initialized()/_ensure_overlay_safe()guards and applied them to several Shapely-compatible accessors and overlay/predicate entrypoints. - Implemented GEOS-backed
Geometry.union()plus convenienceunion()APIs on geometry wrapper classes and at module level. - Added regression tests for overlay safety and updated README/version/pre-commit config.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
togo.pyx |
Adds initialization/overlay safety checks and implements GEOS-backed union() across Geometry APIs. |
tests/test_overlay_safety.py |
Adds regression tests for uninitialized/empty-geometry safety and union behavior. |
README.md |
Updates docs/examples for union and describes the new managed-exception behavior. |
pyproject.toml |
Bumps project version to 0.4.3. |
.pre-commit-config.yaml |
Updates hook revisions (one revision appears invalid). |
mindflayer
changed the title
force_2d plus more segfault-related hardening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.