Skip to content

add (int) in getDefaultParameters()#26

Open
rmdhfz wants to merge 1 commit into
minchao:masterfrom
rmdhfz:dev
Open

add (int) in getDefaultParameters()#26
rmdhfz wants to merge 1 commit into
minchao:masterfrom
rmdhfz:dev

Conversation

@rmdhfz

@rmdhfz rmdhfz commented Nov 12, 2020

Copy link
Copy Markdown

To get the default parameter, int is required. If not :
partner_id and shopid will be strings. That will cause an error

@minchao

minchao commented Nov 12, 2020

Copy link
Copy Markdown
Owner

Hi @rmdhfz

Thank you for pointing this out.

To avoid property type error. Maybe we should prevent users from setting wrong parameters. When the parameter passed in through the constructor of Client is not a int, throw an exception.

@rmdhfz

rmdhfz commented Nov 12, 2020

Copy link
Copy Markdown
Author

You are welcome.
Yes, we should prevent users from setting wrong parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants