feat: emb_list and hybrid (RRF) searchIterator#577
Draft
DashUmEr wants to merge 1 commit into
Draft
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DashUmEr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @DashUmEr! It looks like this is your first PR to milvus-io/milvus-sdk-node 🎉 |
Adds Node SDK support for: - searchIterator() over an emb_list (ArrayOfVector) field. - hybridSearchIterator() fusing dense + emb_list modalities via RRF over the streamed per-modality results. Fusion keys on the primary key, which is force-included in each sub-iterator's output_fields so fusion is correct even when the caller omits the PK. Part of milvus-io/milvus#49906. Tests: test/utils/HybridSearchIterator.spec.ts. Signed-off-by: David <[email protected]>
DashUmEr
force-pushed
the
upstream-pr/emblist-hybrid-iterator
branch
from
June 8, 2026 21:22
ab8c260 to
18194c4
Compare
shanghaikid
marked this pull request as ready for review
June 10, 2026 07:43
shanghaikid
marked this pull request as draft
June 10, 2026 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Node SDK support for:
Pairs with the Milvus server-side emb_list iterator (milvus-io/milvus#49906). Validated live
(both iterators stream correctly over a real collection); tests in HybridSearchIterator.spec.ts.
Note (found in live testing): the RRF fuser keys on each hit's primary key. The shared
formatSearchResult only populates hit.id when the PK is in output_fields, so the hybrid
iterator now force-includes the PK in each sub-iterator's output_fields (and throws if a hit
lacks an id) — otherwise, with the PK omitted, all hits collapse onto one fusion key. The
broader formatSearchResult id-population behavior is pre-existing/upstream and out of scope
here (worth a separate issue). Targets 2.6; can retarget main. Draft.