Config: don't use more light steps than exist#33
Open
LRitzdorf wants to merge 2 commits into
Open
Conversation
Violating this means attempting to use more steps than actually exist, which writes too high a brightness and generates an "invalid argument" error from the sysfs. Fixes mikhail-m1#30
LRitzdorf
force-pushed
the
light-steps-limit
branch
from
April 18, 2026 01:50
b3375da to
b900fe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to use more steps than actually exist (by setting a
light_Nvalue equal or greater thanlight_steps) writes too high a brightness to the sysfs backlight node, generating an "invalid argument" error.Currently, this uses
.filter()to map invalid light values toNone, which will generate anInvalidPointsInConfigerror later. This seems pretty consistent with existing behavior, erroring when invalid values are provided.The other option is to just clamp any excessively high values to the largest allowed (
light_steps- 1), and continuing without error. This was my first thought, but it feels misleading to the user to just silently allow this.This PR also updates the example config file to obey the light-step limit.
Fixes #30