Skip to content

Added 'audit' zsh script - #3

Open
Phil-Venter wants to merge 3 commits into
mig82:masterfrom
Phil-Venter:patch-1
Open

Added 'audit' zsh script#3
Phil-Venter wants to merge 3 commits into
mig82:masterfrom
Phil-Venter:patch-1

Conversation

@Phil-Venter

Copy link
Copy Markdown

I am enjoying viskit, helps me clean the codebase... I couldn't find a way to 'audit' the project as a whole, so I wrote a zsh script to call most of the informative viskit commands.

@mig82

mig82 commented Mar 19, 2020

Copy link
Copy Markdown
Owner

Hi @Phil-Venter. I'm glad you like it. I've just added a couple more commands to it. I like your idea. Would you perhaps consider updating your PR to use those commands as well before I merge it?

Added support for theme and locale so  more commands (like find-skins, find-dupe-skins, find-font-references, find-dupe-i18ns) can be run as well
@Phil-Venter

Copy link
Copy Markdown
Author

I think the zsh script includes most of the commands now

find-actions
find-views
find-widgets
find-orphan-widgets
find-autogrow-widgets
find-redundant-containers
find-skins
count-skin-uses
find-dupe-skins
find-font-references
find-dupe-i18ns
find-images

let me know if I'm missing one you think should be included

@mig82

mig82 commented Apr 7, 2020

Copy link
Copy Markdown
Owner

Hi Phil. Looking at this again to merge it. I'm confused as to how you're using the script. See, the idea is to have Viskit installed globally npm install -g viskit and then to be able to run it on any project anywhere in the file system —e.g. like viskit fv path/to/project. How are you running the script from anywhere? Are you adding it to your PATH?

@Phil-Venter

Copy link
Copy Markdown
Author

I did not, I created an alias in my .zshrc file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants