fix(perf): op-tracing preflight check before benchmark run#330
Closed
xieofxie wants to merge 6 commits into
Closed
fix(perf): op-tracing preflight check before benchmark run#330xieofxie wants to merge 6 commits into
xieofxie wants to merge 6 commits into
Conversation
Move is_qnn_profiling_available() preflight check to before PerfBenchmark.run() so the command fails fast instead of wasting a full benchmark run. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
tezheng
approved these changes
Apr 14, 2026
Collaborator
tezheng
left a comment
tezheng
left a comment
There was a problem hiding this comment.
LGTM. The preflight check is correctly placed at the try-block level (covers both ONNX and HF paths) before benchmark.run(). Old duplicate check properly removed. Ruff clean.
Minor note (non-blocking):
- Could add an ONNX-path test to complement the HF-path test, but not a blocker.
Contributor
Author
|
dup of #397 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_qnn_profiling_available()check to beforePerfBenchmark.run()sowmk perf --op-tracingfails fast instead of wasting a full benchmark run whenonnxruntime-qnnis not installed.Test plan
TestOpTracingPreflight::test_benchmark_does_not_run_when_qnn_unavailable— verifiesPerfBenchmark.run()is never called when QNN profiling is unavailable and exit code is non-zeroExtracted from #209 (Bug A only).
🤖 Generated with Claude Code