Skip to content

Hide agent host tip if user manual selects via picker#322667

Open
anthonykim1 wants to merge 1 commit into
mainfrom
anthonykim1/continueInDoesNotGoAway
Open

Hide agent host tip if user manual selects via picker#322667
anthonykim1 wants to merge 1 commit into
mainfrom
anthonykim1/continueInDoesNotGoAway

Conversation

@anthonykim1

Copy link
Copy Markdown
Contributor

Resolves: #322453

  • Make chat input notifications evaluate session-type filters against the pending delegation target before the backing session resource.
  • Rerender input notifications when the user changes the pending delegation target from the session picker.
  • Preserve model-pool validation semantics by leaving getCurrentSessionType() based on the real session resource.
  • Add a browser regression test covering local-only notification visibility when switching to and from Agent Host.

Inspirations from:

@anthonykim1 anthonykim1 self-assigned this Jun 24, 2026
Copilot AI review requested due to automatic review settings June 24, 2026 04:13
@anthonykim1 anthonykim1 marked this pull request as ready for review June 24, 2026 04:13
@anthonykim1 anthonykim1 enabled auto-merge (squash) June 24, 2026 04:13
@anthonykim1 anthonykim1 added this to the 1.127.0 milestone Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes chat input notification visibility when the user switches the session target via the session picker (e.g. “Continue in Agent Host”), by evaluating session-type-gated notifications against the pending delegation target and forcing a rerender when that pending target changes.

Changes:

  • Added getNotificationSessionType() so input notification filtering prefers _pendingDelegationTarget (then _currentSessionType, then the real session resource type).
  • Triggered ChatInputNotificationWidget.rerender() when the pending delegation target changes via the picker, ensuring session-type-gated tips hide/show immediately.
  • Added a browser regression test to verify rerendering updates session-type filtering behavior.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Uses a notification-specific “effective session type” and rerenders notifications when the pending delegation target changes.
src/vs/workbench/contrib/chat/test/browser/widget/input/chatInputNotificationWidget.test.ts Adds a regression test for session-type-gated notification visibility when the session type provider changes and rerender() is invoked.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

@anthonykim1 anthonykim1 marked this pull request as draft June 24, 2026 04:53
auto-merge was automatically disabled June 24, 2026 04:53

Pull request was converted to draft

@anthonykim1 anthonykim1 marked this pull request as ready for review June 24, 2026 04:57
@anthonykim1 anthonykim1 enabled auto-merge (squash) June 24, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Continue in Agent Host leads to a half-broken chat input

2 participants