Hide agent host tip if user manual selects via picker#322667
Open
anthonykim1 wants to merge 1 commit into
Open
Hide agent host tip if user manual selects via picker#322667anthonykim1 wants to merge 1 commit into
anthonykim1 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes chat input notification visibility when the user switches the session target via the session picker (e.g. “Continue in Agent Host”), by evaluating session-type-gated notifications against the pending delegation target and forcing a rerender when that pending target changes.
Changes:
- Added
getNotificationSessionType()so input notification filtering prefers_pendingDelegationTarget(then_currentSessionType, then the real session resource type). - Triggered
ChatInputNotificationWidget.rerender()when the pending delegation target changes via the picker, ensuring session-type-gated tips hide/show immediately. - Added a browser regression test to verify rerendering updates session-type filtering behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Uses a notification-specific “effective session type” and rerenders notifications when the pending delegation target changes. |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatInputNotificationWidget.test.ts | Adds a regression test for session-type-gated notification visibility when the session type provider changes and rerender() is invoked. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #322453
getCurrentSessionType()based on the real session resource.Inspirations from:
ChatInputPart.getCurrentSessionType.ChatInputNotificationWidget.rerender.LocalAgentDisabledInputTipContribution.