Skip to content

[rappture] fix build with c++17#52210

Merged
BillyONeal merged 1 commit into
microsoft:masterfrom
AenBleidd:vko_rappture_fix_build_with_c++17
Jun 5, 2026
Merged

[rappture] fix build with c++17#52210
BillyONeal merged 1 commit into
microsoft:masterfrom
AenBleidd:vko_rappture_fix_build_with_c++17

Conversation

@AenBleidd

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Copilot AI review requested due to automatic review settings June 5, 2026 14:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates the vcpkg rappture port to a new port-version to incorporate a C++17 compatibility fix, and updates the corresponding version/baseline metadata.

Changes:

  • Bump rappture port-version from 4 to 5 across the port, baseline, and versions metadata
  • Add and apply a new patch to remove use of std::binary_function (removed in C++17)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
versions/r-/rappture.json Adds a new version entry for rappture 1.9 with port-version 5 and updated git-tree.
versions/baseline.json Updates the baseline port-version for rappture to 5.
ports/rappture/vcpkg.json Bumps the port-version to 5.
ports/rappture/portfile.cmake Applies the new C++17 fix patch during source extraction.
ports/rappture/fix_c++17.patch Patch removing std::binary_function inheritance to support C++17 builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ports/rappture/portfile.cmake Outdated
Comment thread ports/rappture/portfile.cmake Outdated
Signed-off-by: Vitalii Koshura <[email protected]>
@AenBleidd AenBleidd force-pushed the vko_rappture_fix_build_with_c++17 branch from 434d267 to 1e3808a Compare June 5, 2026 14:05
@BillyONeal

Copy link
Copy Markdown
Member

@microsoft-github-policy-service rerun

@BillyONeal BillyONeal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT 5.4 ( #52189 ) notes that the installed configs are broken but I'm going to merge this anyway because it's not a regression from this change

  1. find_package(rappture CONFIG REQUIRED) is broken on the installed package

The exported target in share/rappture/rappture-config.cmake sets INTERFACE_LINK_LIBRARIES to expat::expat;ZLIB::ZLIB, but the package config does not call find_dependency() (or otherwise define those imported targets) before exporting unofficial::rappture::rappture (installed\x64-windows\share\rappture\rappture-config.cmake:57-64).

@BillyONeal BillyONeal merged commit 40e35a2 into microsoft:master Jun 5, 2026
16 checks passed
@AenBleidd AenBleidd deleted the vko_rappture_fix_build_with_c++17 branch June 6, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants