[rappture] fix build with c++17#52210
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the vcpkg rappture port to a new port-version to incorporate a C++17 compatibility fix, and updates the corresponding version/baseline metadata.
Changes:
- Bump
rapptureport-version from 4 to 5 across the port, baseline, and versions metadata - Add and apply a new patch to remove use of
std::binary_function(removed in C++17)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| versions/r-/rappture.json | Adds a new version entry for rappture 1.9 with port-version 5 and updated git-tree. |
| versions/baseline.json | Updates the baseline port-version for rappture to 5. |
| ports/rappture/vcpkg.json | Bumps the port-version to 5. |
| ports/rappture/portfile.cmake | Applies the new C++17 fix patch during source extraction. |
| ports/rappture/fix_c++17.patch | Patch removing std::binary_function inheritance to support C++17 builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Vitalii Koshura <[email protected]>
434d267 to
1e3808a
Compare
|
@microsoft-github-policy-service rerun |
BillyONeal
left a comment
There was a problem hiding this comment.
GPT 5.4 ( #52189 ) notes that the installed configs are broken but I'm going to merge this anyway because it's not a regression from this change
find_package(rappture CONFIG REQUIRED)is broken on the installed packageThe exported target in
share/rappture/rappture-config.cmakesetsINTERFACE_LINK_LIBRARIEStoexpat::expat;ZLIB::ZLIB, but the package config does not callfind_dependency()(or otherwise define those imported targets) before exportingunofficial::rappture::rappture(installed\x64-windows\share\rappture\rappture-config.cmake:57-64).
./vcpkg x-add-version --alland committing the result.