Skip to content

Guard and tidy a couple instances of GetActiveTerminalControl#20458

Open
DHowett wants to merge 1 commit into
mainfrom
dev/duhowett/meh-probably-shouldnt-crash-when-this-happens
Open

Guard and tidy a couple instances of GetActiveTerminalControl#20458
DHowett wants to merge 1 commit into
mainfrom
dev/duhowett/meh-probably-shouldnt-crash-when-this-happens

Conversation

@DHowett

@DHowett DHowett commented Jul 21, 2026

Copy link
Copy Markdown
Member

This regressed with #19136.

Closes #20457

@carlos-zamora carlos-zamora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the quick turnaround haha. Nice work

@github-project-automation github-project-automation Bot moved this to To Cherry Pick in 1.25 Servicing Pipeline Jul 21, 2026
@github-project-automation github-project-automation Bot moved this to To Cherry Pick in 1.24 Servicing Pipeline Jul 21, 2026
@carlos-zamora carlos-zamora moved this from To Cherry Pick to To Consider in 1.24 Servicing Pipeline Jul 21, 2026
@carlos-zamora carlos-zamora moved this from To Cherry Pick to To Consider in 1.25 Servicing Pipeline Jul 21, 2026
@DHowett DHowett moved this from To Consider to To Cherry Pick in 1.24 Servicing Pipeline Jul 21, 2026
@DHowett DHowett moved this from To Consider to To Cherry Pick in 1.25 Servicing Pipeline Jul 21, 2026
@DHowett
DHowett enabled auto-merge (squash) July 21, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Cherry Pick
Status: To Cherry Pick

Development

Successfully merging this pull request may close these issues.

ScrollUp can crash when the active tab has no terminal control

3 participants