Skip to content

Fix razzle.cmd: correct MSBuild PATH, VS version range, and exit codes#20451

Merged
DHowett merged 2 commits into
microsoft:mainfrom
DinahK-2SO:user/DinahK-2SO/fix-razzle
Jul 20, 2026
Merged

Fix razzle.cmd: correct MSBuild PATH, VS version range, and exit codes#20451
DHowett merged 2 commits into
microsoft:mainfrom
DinahK-2SO:user/DinahK-2SO/fix-razzle

Conversation

@DinahK-2SO

@DinahK-2SO DinahK-2SO commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

  • Real exit codes: errors now exit /b 1, success exit /b 0. Old goto :EXIT fell off the end returning success even on error.
  • Correct PATH: append MSBuild's bin dir with a ;. Old terminal had no separator (glued onto the last entry) and used fragile terminal.
  • Pin VS [17.0,19.0): -latest -prerelease picked any newest VS; for old versions like VS2019 doesn't support building *.slnx (OpenConsole.slnx)
  • Guard MSBuild exists: fail fast with fix-it guidance instead of a later cryptic '""' is not recognized.
  • Quote "%VSWHERE%": launch vswhere via a quoted path. Unquoted, a repo cloned under a path with spaces (e.g. C:\Users\First terminal.) fails to run vswhere, leaving MSBUILD unset so razzle errors out.
  • Consistent casing: MsBuild -> MSBuild in status/error text (cosmetic).

References and Relevant Issues

Nah

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Run local build

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

Dinah Gao (from Dev Box) added 2 commits July 20, 2026 16:11
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@lhecker lhecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread tools/razzle.cmd
@DHowett
DHowett enabled auto-merge (squash) July 20, 2026 16:51
@DHowett

DHowett commented Jul 20, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.

@DHowett
DHowett disabled auto-merge July 20, 2026 16:57
@DHowett
DHowett merged commit 11fe2ab into microsoft:main Jul 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants