doc: fix stale build guidance in doc/building.md#20450
Open
nsfxdyj wants to merge 1 commit into
Open
Conversation
The repository no longer uses git submodules, so drop the submodule restore instructions from doc/building.md (there is no .gitmodules). Also add a Troubleshooting section covering the two NuGet restore failures reported in microsoft#17880: - NU1101 for Microsoft.*.App.Ref packages: these ship with the .NET SDK (8.0 and 10.0 are required), not with the configured feeds. - 401 (Unauthorized) from the TerminalDependencies feed: guidance for clearing stale cached credentials. Fixes microsoft#17880
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
You and #20400 will need to fight it out I guess. |
Contributor
Author
|
@DHowett Ha, fair! I took a look at #20400 and it's a clear superset of what I have here (the nuget.exe upgrade and the deploy-walkthrough fixes are genuinely valuable, and it covers the same submodule/NuGet points). Happy to let that one land first — I can rebase afterward to fill in any remaining gaps, or close this PR if it ends up fully covered. Whichever you prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17880. Updates
doc/building.mdto match how the repository actually builds today:git submodule update --init --recursiveinstructions. The repository no longer uses git submodules (there is no.gitmodulesfile), so this step silently does nothing and confuses new contributors.NU1101: Unable to find package Microsoft.*.App.Ref— these reference packages ship with the .NET SDK (8.0 and 10.0, both in.vsconfig), not with the configured feeds.401 (Unauthorized)from theTerminalDependenciesAzure Artifacts feed — the feed allows anonymous read access; a 401 is typically caused by stale cached credentials, with guidance on how to clear them.Verified against a fresh clone + full local build (x64 Debug, 0 errors).