Sync CCF version to 7.0.5, update constitution, and clean up constants#408
Open
andpiccione wants to merge 7 commits into
Open
Sync CCF version to 7.0.5, update constitution, and clean up constants#408andpiccione wants to merge 7 commits into
andpiccione wants to merge 7 commits into
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…b.com/microsoft/scitt-ccf-ledger into users/apiccione/705-sync-constitution
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
andpiccione
changed the title
andpiccione
commented
Jun 15, 2026
| std::string context; | ||
| // @context may be a single string or an array of strings per the W3C DID | ||
| // spec, so it is stored as raw JSON rather than a fixed type. | ||
| nlohmann::json context = {}; |
Member
Author
There was a problem hiding this comment.
This change was necessary due to microsoft/didx509cpp#41 (consumed via CCF 7.0.5). Using nlohmann::json should work well, as it handles both strings and arrays. I checked that this should not introduce any backward compatibility issues, since the DIDDocument is only resolved and parsed during the POST request processing and is not stored in the ledger (only the raw COSE statement is persisted).
@achamayou, could you please confirm that this change is acceptable and will not cause compatibility issues with live instances?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the CCF version to 7.0.5 across relevant files and remove unused constants to streamline the codebase. Additionally, sync the default constitution based on the latest CCF updates.