[webpack-plugin-utilities] Add evaluateConstantEstreeExpression#5848
Open
iclanton wants to merge 1 commit into
Open
[webpack-plugin-utilities] Add evaluateConstantEstreeExpression#5848iclanton wants to merge 1 commit into
iclanton wants to merge 1 commit into
Conversation
Rename evaluateAcornNode to evaluateConstantEstreeExpression and remove the hand-rolled IAcornNode interface in favor of @types/estree types. - Use proper ESTree types, handling object spread elements, private/ computed property keys, and sparse array holes correctly. - Support UnaryExpression (e.g. negative numbers like -1) and no-substitution TemplateLiteral nodes. - Add a TSDoc comment describing usage, supported nodes, and limitations. - Add unit tests covering all supported node types and error paths. - Update the hashed-folder-copy-plugin consumer accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the
evaluateAcornNodehelper in@rushstack/webpack-plugin-utilities:evaluateAcornNode→evaluateConstantEstreeExpression(the previous name referenced the parser rather than the node shape it operates on).IAcornNodeinterface in favor of the existing@types/estreetypes. This surfaced and fixed a few latent correctness gaps that the oldany-ish casts hid:SpreadElements ({ ...other }) are now explicitly rejected instead of silently mis-evaluated,[1, , 3]) now evaluate tonullinstead of being passed into the recursion.UnaryExpression— notably negative numbers like-1, which parse as a unary-applied to a literal and previously threw. Also supports+,!,~.TemplateLiteralwith no${...}substitutions.testphase for the package, which previously had none.hashed-folder-copy-pluginconsumer to the new name.Details
test/_phase:testscripts were added (the rig already provides the test phase + config).How it was tested
rush buildandrush testfor@rushstack/webpack-plugin-utilities, plus a build of thehashed-folder-copy-pluginconsumer.