Remove EverCrypt support#59
Merged
Merged
Conversation
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes EverCrypt integration from merklecpp’s build and test infrastructure, cleaning up test/benchmark code paths that depended on EverCrypt while keeping the OpenSSL-based benchmarks available when OpenSSL is enabled.
Changes:
- Removed the
EVERCRYPTCMake option and the EverCrypt external build wiring (including C/ASM language requirements). - Deleted the dedicated EverCrypt comparison test and removed EverCrypt hooks from shared benchmark/test programs.
- Kept the OpenSSL-only hash benchmarks/tests gated behind
OPENSSL.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Drops C/ASM project languages and removes EverCrypt option + external library wiring. |
test/CMakeLists.txt |
Removes the EverCrypt-only test and gates hash comparison/bench test on OPENSSL only. |
test/compare_evercrypt.cpp |
Deleted EverCrypt comparison test program. |
test/compare_hash_functions.cpp |
Removes EverCrypt comparison/benchmark paths, leaving merklecpp/OpenSSL benchmark paths. |
test/time_large_trees.cpp |
Removes EverCrypt benchmark path and updates benchmark labeling. |
test/demo_tree.cpp |
Removes EverCrypt include hook. |
test/serialise_to_file.cpp |
Removes EverCrypt include hook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
cjen1-msft
reviewed
Jul 14, 2026
cjen1-msft
approved these changes
Jul 14, 2026
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing