Skip to content

Remove EverCrypt support#59

Merged
achamayou merged 3 commits into
microsoft:mainfrom
achamayou:evercrypt-remove
Jul 14, 2026
Merged

Remove EverCrypt support#59
achamayou merged 3 commits into
microsoft:mainfrom
achamayou:evercrypt-remove

Conversation

@achamayou

Copy link
Copy Markdown
Member

Summary

  • remove the EverCrypt CMake option, external build wiring, and C/ASM language requirements
  • delete the dedicated comparison test and strip EverCrypt hooks from shared tests
  • retain the OpenSSL-only hash benchmarks

Testing

  • default Debug build and CTest suite
  • OpenSSL-enabled Debug build and CTest suite

Copilot AI review requested due to automatic review settings July 14, 2026 13:34
@achamayou
achamayou requested a review from a team as a code owner July 14, 2026 13:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes EverCrypt integration from merklecpp’s build and test infrastructure, cleaning up test/benchmark code paths that depended on EverCrypt while keeping the OpenSSL-based benchmarks available when OpenSSL is enabled.

Changes:

  • Removed the EVERCRYPT CMake option and the EverCrypt external build wiring (including C/ASM language requirements).
  • Deleted the dedicated EverCrypt comparison test and removed EverCrypt hooks from shared benchmark/test programs.
  • Kept the OpenSSL-only hash benchmarks/tests gated behind OPENSSL.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CMakeLists.txt Drops C/ASM project languages and removes EverCrypt option + external library wiring.
test/CMakeLists.txt Removes the EverCrypt-only test and gates hash comparison/bench test on OPENSSL only.
test/compare_evercrypt.cpp Deleted EverCrypt comparison test program.
test/compare_hash_functions.cpp Removes EverCrypt comparison/benchmark paths, leaving merklecpp/OpenSSL benchmark paths.
test/time_large_trees.cpp Removes EverCrypt benchmark path and updates benchmark labeling.
test/demo_tree.cpp Removes EverCrypt include hook.
test/serialise_to_file.cpp Removes EverCrypt include hook.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/compare_hash_functions.cpp
Comment thread test/compare_hash_functions.cpp
@achamayou
achamayou merged commit f6064af into microsoft:main Jul 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants