ci(deps): allow-list ecdsa GHSA-wj6h-64fc-37mp in dependency review#642
Merged
Conversation
The checkov bump in Dependabot PR #629 introduces a new transitive dependency ecdsa==0.19.2, flagged by GHSA-wj6h-64fc-37mp (Minerva timing attack on P-256, high severity). No fixed upstream version exists, so the dependency-review-action gate cannot be satisfied by a version bump. Add the advisory to allow-ghsas so the pip group bump can pass. Re-evaluate when checkov drops the ecdsa dependency. Refs #641
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
=======================================
Coverage 31.80% 31.80%
=======================================
Files 40 40
Lines 6015 6015
=======================================
Hits 1913 1913
Misses 4102 4102
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bindsi
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Dependency Review gate in the PR Validation workflow was failing on the open Dependabot pip-group update (#629). Its only high-severity finding was ecdsa 0.19.2 (GHSA-wj6h-64fc-37mp, "Minerva timing attack on P-256"), a new transitive dependency introduced by the checkov 3.2.529 → 3.3.5 bump. The advisory has no fixed upstream version, so no dependency bump can satisfy
fail-on-severity: high.This change adds a narrowly-scoped
allow-ghsasentry for that single advisory to the Dependency Review step in .github/workflows/pr-validation.yml, with inline comments documenting the rationale and a pointer to re-evaluate when checkov drops the ecdsa dependency. No other workflow settings change.Related Issue
Fixes #641
Type of Change
Implementation Details
Added
allow-ghsas: GHSA-wj6h-64fc-37mpto theactions/dependency-review-actionstep within thedependency-scanjob. Thefail-on-severity: high,warn-on-openssf-scorecard-level: 3, andcomment-summary-in-pr: on-failuresettings are unchanged, so the gate still fails on every other high-or-higher advisory. Two preceding comments record that ecdsa is affected by a side-channel with no upstream fix, that it is transitive via checkov, and that the suppression should be revisited when that dependency is dropped.Testing Performed
Validation Steps
Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codeSecurity Review
Additional Notes
This intentionally suppresses one known advisory (GHSA-wj6h-64fc-37mp) because no patched ecdsa release exists; the python-ecdsa maintainers treat the Minerva side-channel as out of scope. The suppression mirrors the existing transitive-with-no-fix pattern documented in osv-scanner.toml (which feeds osv-scanner rather than the Dependency Review action). Re-evaluate and remove the entry once checkov no longer pulls in ecdsa.
Screenshots (if applicable)