chore: upgrade microsoft/fabric provider to 1.10.0#640
Open
PratikWayase wants to merge 2 commits into
Open
Conversation
| display_name = var.workspace_display_name | ||
| description = var.workspace_description | ||
| capacity_id = var.capacity_id | ||
| skip_capacity_state_validation = true |
Contributor
There was a problem hiding this comment.
skip_capacity_state_validation = true is hardcoded here without an input variable, which means every deployment (including production) skips Fabric capacity state validation. The codebase convention for internal modules requires all variables to be required with no defaults.
Consider adding a required variable to the module:
variable "skip_capacity_state_validation" {
type = bool
description = "When true, skips validation of Fabric capacity state during workspace provisioning. Useful for non-production environments where capacity may be paused."
}Then thread it through src/000-cloud/031-fabric/terraform/main.tf when calling module.fabric_workspace, and set it to true in the CI deployment config (src/000-cloud/031-fabric/ci/terraform/). This lets production callers opt out of skipping validation, giving them a faster failure signal when deploying against a paused or misconfigured capacity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the
microsoft/fabricTerraform provider from 1.3.0 to 1.10.0 across all Fabric-related Terraform components and blueprints. This PR also enablesskip_capacity_state_validation = truefor the Fabric workspace resource to avoid validation failures when non-production Fabric capacities are paused or suspended.Related Issue
Fixes #494
Type of Change
Implementation Details
1.10.0.>= 1.3.0constraint with a pinned1.10.0version.skip_capacity_state_validation = trueto the Fabric workspace resource as recommended in the issue description.Testing Performed
terraform validate/npm run tf-validate) could not be executed locally because an Azure subscription is required. CI will perform validation.Validation Steps
1.10.0.npm run tf-validate.npm run tflint-fix-all.Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codeSecurity Review