Match settings checkbox alignment and labels to Windows ZoomIt - #38
Merged
Conversation
- Add Windows-style checkbox helpers (caption left, box right) and a column helper that aligns the boxes in a right-hand column. - Convert Zoom, Break, Snip, Record, DemoType, and webcam checkboxes to the Windows box-on-right style and update captions/labels to match the Windows ZoomIt options dialog wording. - Align the webcam Camera/Position and Size/Shape rows in a grid. - Move the Record tab's Edit existing video (Trim) row to the bottom.
There was a problem hiding this comment.
Pull request overview
Aligns the macOS Settings window layout and wording with the Windows ZoomIt options dialog by introducing Windows-style checkbox layout helpers and updating multiple settings panes to use right-aligned checkbox boxes and Windows-matching captions/labels.
Changes:
- Added reusable helpers for Windows-style checkboxes (caption-left / box-right) and for stacking them with aligned checkbox boxes.
- Updated checkbox layout and captions across multiple tabs (Zoom, Break, Snip, Record, DemoType, Webcam) to match Windows wording and alignment.
- Reworked Webcam rows into a grid for consistent label/popup alignment and moved the Record tab’s Trim row to the bottom.
Comments suppressed due to low confidence (1)
Sources/ZoomItMacCore/Settings/SettingsWindowController.swift:1288
- The “Noise cancellation” checkbox label was updated, but the tooltip strings still describe “wind noise removal”, which makes the UI help text inconsistent/confusing. Consider updating the tooltip text to match the new wording while still mentioning the underlying AVFoundation feature.
noiseCancellationCheckbox?.title = supported ? "Noise cancellation:" : "Noise cancellation (not supported by selected microphone):"
noiseCancellationCheckbox?.isEnabled = supported
noiseCancellationCheckbox?.state = (settings.recordNoiseCancellation && supported) ? .on : .off
noiseCancellationCheckbox?.toolTip = supported
? "Uses AVFoundation wind noise removal for the selected microphone."
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| liveHotKeyButton.widthAnchor.constraint(greaterThanOrEqualToConstant: 140).isActive = true | ||
| self.liveHotKeyButton = liveHotKeyButton | ||
| let liveHotKeyRow = makeRow([makeLabel("Live zoom toggle:"), liveHotKeyButton]) | ||
| let liveHotKeyRow = makeRow([makeLabel("LiveZoom Toggle:"), liveHotKeyButton]) |
Comment on lines
+1302
to
1303
| let enableCheck = makeCheckbox("", action: #selector(webcamEnabledChanged(_:)), state: settings.webcamEnabled) | ||
|
|
MarioHewardt
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the macOS settings panes with the Windows ZoomIt options dialog.
Changes
BS_LEFTTEXT), plus a column helper that aligns the boxes in a right-hand column.Testing
./Scripts/build-app.sh debugbuilds cleanly; launched and verified the settings panes visually.