Display bundled app version in settings - #37
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the app’s settings footer version display to reflect the version embedded in the app bundle (with a development fallback), and adds a self-test to lock in the intended resolution behavior.
Changes:
- Replace
AppInfo.versionhardcoded string with a computed value resolved fromBundle.main.infoDictionary. - Add
AppInfo.resolveVersion(from:)helper that prefersCFBundleShortVersionString, then falls back toCFBundleVersion, else returns"Development". - Add a self-test validating the resolution rules for short version, build version fallback, and unbundled development builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/ZoomItMacCore/App/AppInfo.swift | Derives AppInfo.version from bundle metadata with a development fallback and a testable resolver helper. |
| Sources/ZoomItMacCore/SelfTest/SelfTestRunner.swift | Adds coverage ensuring version resolution behaves as intended for settings display. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chakrik73
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.