Fix menu-bar manager conflict, first-launch Settings, and hotkeys while Settings open

[jldeen]

Summary

Fixes three related menu-bar / Settings issues that together made ZoomIt hard to reach and configure, especially alongside third-party menu-bar managers.

1. Menu-bar icon fights menu-bar managers (Bartender) — fixes #27

AppDelegate.makeStatusItem set an autosaveName, which makes AppKit persist and re-assert an absolute menu-bar X position on every relaunch/relayout. Managers like Bartender and Ice bucket items by position, so the icon kept snapping back out of the user's chosen section and wouldn't stay put. Removed the autosaveName so the system places the item and managers can organize it freely. Verified across multiple clean launch/quit cycles that no NSStatusItem Preferred Position key is written afterward.

2. Fresh install doesn't open Settings — fixes #21

On a brand-new install the app launched menu-bar-only with no visible entry point (compounded by #27 when the icon was hidden). Now a fresh install opens Settings once so the user has a clear starting point. Upgrading users are detected as returning via an existing-preference migration sentinel, so they don't get an unexpected pop-up, and the completion flag is persisted so later launches don't depend on the sentinel.

3. Zoom toggle hotkey fails while Settings is open — fixes #22

The global hotkeys were suspended for the entire time the Settings dialog was open, so pressing the Zoom toggle (or any shortcut) while Settings was open beeped and did nothing. Scoped the suspension to active shortcut recording only, with a balanced resume that fires no matter how recording ends (successful capture, Esc, toggling the button, or window close). Shortcuts now keep working while Settings is merely open.

How this was verified

• swift build — clean.
• swift run ZoomItMacSelfTest — PASS, including a new testFirstLaunchFlag covering the fresh-launch state, flag persistence across store instances, and the upgrade migration sentinel.
• Runtime (dev app bundle):
  • Fresh install opens Settings on first launch; second launch does not reopen it.
  • Upgrade migration (existing prefs, no flag) does not pop Settings.
  • 5 clean single-instance launch/quit cycles: no NSStatusItem Preferred Position key written.
  • Bartender confirmed able to keep the icon in "Shown Items".
  • Zoom toggle hotkey fails while Settings dialog is open #22: with Settings open, sending the Zoom toggle activated zoom (window count 1 → 2 → 1 after Esc) with no beep/suppression.

Files changed

• Sources/ZoomItMacCore/App/AppDelegate.swift — remove autosaveName; first-launch Settings.
• Sources/ZoomItMacCore/Settings/SettingsStore.swift — first-launch flag + upgrade migration.
• Sources/ZoomItMacCore/Settings/SettingsWindowController.swift — scope hotkey suspend/resume to recording.
• Sources/ZoomItMacCore/SelfTest/SelfTestRunner.swift — self-test for the first-launch flag + migration.

Closes #21
Closes #22
Closes #27

[jldeen]

@microsoft-github-policy-service agree company="GitHub"