Fix audio resampling: use librosa.resample instead of np.interp#386
Open
hobostay wants to merge 1 commit into
Open
Fix audio resampling: use librosa.resample instead of np.interp#386hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
np.interp performs linear interpolation on the waveform samples, which is not a valid resampling method. It introduces aliasing artifacts by not applying an anti-aliasing filter before decimation/interpolation. Replace with librosa.resample which uses proper band-limited sinc interpolation. librosa is already a dependency used elsewhere in the project (vibevoice_tokenizer_processor.py, vibevoice_asr_processor.py). Co-Authored-By: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.interp(linear waveform interpolation) withlibrosa.resamplefor audio resampling indemo/vibevoice_asr_inference_from_file.pynp.interpis not a valid resampling method — it introduces aliasing artifacts by not applying an anti-aliasing filter before decimation/interpolationlibrosa.resampleuses proper band-limited sinc interpolationDetails
Affected file:
demo/vibevoice_asr_inference_from_file.py(lines 325-332)The original code used
np.interpto downsample audio waveforms by linearly interpolating sample values. This approach does not include an anti-aliasing filter, so high-frequency components fold back into the audible range as artifacts.librosa.resampleis already used elsewhere in this project (vibevoice_tokenizer_processor.py,vibevoice_asr_processor.py).Test plan
🤖 Generated with Claude Code